Handle spurious failure were rename succeeded but reported it failed (#1588) #1594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tushardhadiwal
changed the title
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/DatafileManager.java
Outdated
Show resolved
Hide resolved
Contributor
|
I think #1588 is a more general issue that could still be beneficial and be done at some point in the future. Could change the commit message for this PR to something like |
tushardhadiwal
changed the title
…apache#1588) PR addresses a few issues: Spurious rename failures where rename failed but actually succeeded The check for file existence should only be done before attempting rename Should not delete file if it exists (an admin may want to investigate).
keith-turner
approved these changes
Apr 27, 2020
arvindshmicrosoft
approved these changes
Apr 28, 2020
Contributor
|
@tushardhadiwal thanks for the contribution. If you would like to be listed as a contributor on the people page, please submit a PR to add yourself. Let me know if you have any questions about editing the website. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1588 : Refine rename during minor compaction
PR addresses a few issues: