Move MinorCompaction method call into retry catch block. Fixes #1298#1675
Merged
milleruntime merged 1 commit intoapache:1.9from Aug 12, 2020
Merged
Move MinorCompaction method call into retry catch block. Fixes #1298#1675milleruntime merged 1 commit intoapache:1.9from
milleruntime merged 1 commit intoapache:1.9from
Conversation
…#1298 * Fixes the situation when MinorCompactionTask creates a new File and an IOException leaves the Tablet in a bad state * Moves the new file code into the try/catch block that will retry during an IOException
Member
|
FWIW, I ran all the ITs with this change, and everything passed (except a transient FateStarvationIT failure that is unrelated and which passed on a subsequent run). |
Contributor
Author
Great thank you! |
keith-turner
added a commit
to keith-turner/accumulo
that referenced
this pull request
Aug 14, 2020
keith-turner
added a commit
that referenced
this pull request
Aug 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new File and an IOException leaves the Tablet in a bad state
retry during an IOException
I was not able to create a test for this scenario but I did simulate it by manually throwing the exception in the Tablet code. I ran TableIT with the simulated IOException and it was able to recover.