Validate formatting in CI and releases #1767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctubbsii
added
enhancement
Member
Author
|
I was hoping to get this pushed before @keith-turner pushed 0168e8f to see if I could get it to fail the build, but I didn't make it in time. I'm confident this works, though, because I can simulate it locally. |
Contributor
|
So if someone submits a PR that requires formatting changes, then it should now fail CI? If so thats kinda awesome. |
Member
Author
Yep. 😺 |
asfgit
pushed a commit
that referenced
this pull request
Nov 6, 2020
Minor fixup of #1767 * Remove redundant execution of sortpom verification that existed before the verifyformat profile was created in PR #1767 and keep the original execution phase and execution ID * Deconflict execution IDs for other plugins in the verifyformat profile, so plugin execution definitions don't clobber each other if both verifyformat and autoformat profiles are active
asfgit
pushed a commit
that referenced
this pull request
Nov 26, 2020
* Show rat output in console (partial backport to 1.x from #1767) * Don't skip enforcer when skipQA profile is active, because it is necessary for enforcing build requirements (and isn't costly to run) * Enforce the JDK version to less than 15 for Accumulo 1.x, because Concurrent Mark and Sweep garbage collector options were removed from JDK 15, which Accumulo 1.x uses in its scripts and in Mini. While Accumulo 1.x can still compile and build in JDK 15, it will not be able to run as-is, including running tests, resulting in hard-to-track and confusing errors for developers. It is easier to enforce the JDK version to being at least 11, and strictly less than 15, during development.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.