WIP for #1753. Log error when last tserver is attempted to be stopped. #1770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progess to get opinions and ideas on how to tackle issue #1753. Trying to stop the last tserver using the
Admin.classwill hang indefinitely as detailed in ACCUMULO-3898. Currently, the only way to get around this and actually shutdown the tserver will be to makeforce=truewhen calling the stop command.The idea with these particular changes is to simply check and log an error if there is only one tserver left (therefore hosting the root table) before ever attempting to shut it down. Hopefully this will mitigate this issue while we discuss a more permanent solution. I also included an updated IT from the Jira ticket that I have been using to test in case anyone else wants to use it or has ideas on improving it.
There are some issues that I have ran into so far. For instance,
ShutdownTserver.javawill fail now since it only uses one tserver and will always return prematurely. Another issue I noticed is when I tried to force the shutdown I could never get the IT to pass. It would get stuck on the verification step and eventually timeout.