Clean up some memory manager internals#1826
Merged
milleruntime merged 1 commit intoapache:mainfrom Dec 8, 2020
Merged
Conversation
* Remove unneeded MemoryManagementActions class * Remove unneeded TabletState interface (in server-base) * Move LargestFirstMemoryManager implementation to the tserver jar * Move TabletStateImpl from an inner class in TabletServerResourceManager to its own class named TabletMemoryReport, since that more accurately reflects its purpose (and matches the variable names which are assigned to it); this supersedes PR apache#1823 * Remove TestTabletState in favor of simplified anonymous inner-class to override the `getExtent()` method
milleruntime
approved these changes
Dec 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TabletServerResourceManager to its own class named TabletMemoryReport,
since that more accurately reflects its purpose (and matches the
variable names which are assigned to it); this supersedes PR Rename TabletState interface to TabletMem in tserver #1823
override the
getExtent()method