fixes #1900 Moves volume choosers to SPI#1905
Merged
keith-turner merged 8 commits intoapache:mainfrom Feb 4, 2021
Merged
Conversation
ctubbsii
requested changes
Feb 4, 2021
Member
ctubbsii
left a comment
ctubbsii
left a comment
There was a problem hiding this comment.
Build is failing due to missing license headers in the new classes. These should be automatically added if you build locally and commit before pushing.
PR mostly looks fine to me. I had a few questions that might turn into possible suggestions.
core/src/main/java/org/apache/accumulo/core/spi/fs/VolumeChooserEnvironment.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/accumulo/core/spi/fs/VolumeChooser.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/accumulo/core/spi/fs/VolumeChooser.java
Outdated
Show resolved
Hide resolved
ctubbsii
approved these changes
Feb 4, 2021
Member
ctubbsii
left a comment
ctubbsii
left a comment
There was a problem hiding this comment.
With the license headers added, my review has changed to "Approve", but am still interested in any feedback from my previous review questions/suggestions, if you haven't seen those yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.