Rename master comment/constant/variable references.#1912
Merged
brianloss merged 7 commits intoapache:mainfrom Feb 9, 2021
brianloss:rename-master-refs
Merged
Rename master comment/constant/variable references.#1912brianloss merged 7 commits intoapache:mainfrom brianloss:rename-master-refs
brianloss merged 7 commits intoapache:mainfrom
brianloss:rename-master-refs
Conversation
This change renames reference to master in comments, variable names, constants, etc. to manager. In some deprecated classes whose purpose is to maintain compatibility until the next major release, the references were not renamed. fixes #1642
brianloss
commented
Feb 5, 2021
* Change the constant defining the zookeeper dir where manager lock, tick, and goal state info are stored from masters to managers. * Add a utility to rename the existing masters dir in ZK from masters to managers. * Attempt renaming from SetGoalState, but also allow an admin to invoke directly if desired.
keith-turner
approved these changes
Feb 8, 2021
server/base/src/main/java/org/apache/accumulo/server/log/WalStateManager.java
Outdated
Show resolved
Hide resolved
server/manager/src/main/java/org/apache/accumulo/manager/upgrade/RenameMasterDirInZK.java
Outdated
Show resolved
Hide resolved
server/manager/src/main/java/org/apache/accumulo/manager/upgrade/RenameMasterDirInZK.java
Outdated
Show resolved
Hide resolved
keith-turner
reviewed
Feb 8, 2021
server/manager/src/main/java/org/apache/accumulo/manager/upgrade/RenameMasterDirInZK.java
Outdated
Show resolved
Hide resolved
…de/RenameMasterDirInZK.java Co-authored-by: Keith Turner <kturner@apache.org>
…ateManager.java Co-authored-by: Keith Turner <kturner@apache.org>
ctubbsii
approved these changes
Feb 9, 2021
server/manager/src/main/java/org/apache/accumulo/manager/upgrade/RenameMasterDirInZK.java
Show resolved
Hide resolved
Contributor
|
Hey @brianloss - Do you know if client code needs to be updated with these changes? I just tried a fresh setup in Uno with these changes included and my client is hanging on a table create. I thought the old client would work but that might not be the case. at org.apache.accumulo.fate.util.UtilWaitThread.sleepUninterruptibly(UtilWaitThread.java:57)
at org.apache.accumulo.core.clientImpl.MasterClient.getConnectionWithRetry(MasterClient.java:52)
at org.apache.accumulo.core.clientImpl.TableOperationsImpl.beginFateOperation(TableOperationsImpl.java:258)
at org.apache.accumulo.core.clientImpl.TableOperationsImpl.doFateOperation(TableOperationsImpl.java:365)
at org.apache.accumulo.core.clientImpl.TableOperationsImpl.doFateOperation(TableOperationsImpl.java:355)
at org.apache.accumulo.core.clientImpl.TableOperationsImpl.doTableFateOperation(TableOperationsImpl.java:1694)
at org.apache.accumulo.core.clientImpl.TableOperationsImpl.create(TableOperationsImpl.java:246)
at org.apache.accumulo.core.clientImpl.TableOperationsImpl.create(TableOperationsImpl.java:216)
at org.apache.accumulo.testing.randomwalk.multitable.CreateTable.visit(CreateTable.java:48)
at org.apache.accumulo.testing.randomwalk.Module.visit(Module.java:237)
at org.apache.accumulo.testing.randomwalk.Framework.run(Framework.java:48)
at org.apache.accumulo.testing.randomwalk.Framework.main(Framework.java:92)
|
Member
Author
@milleruntime with renaming the MasterClient class, yes, that means client code needs to be updated. I called out the incompatibility in my PR for the release notes. Before making the known breaking change, I had tried running a 2.0 client against a 2.1 server (or maybe I tested the reverse, now I don't recall for certain) and while the client came up, a scan against the metadata table hung. So I figured we already weren't compatible. |
Member
Author
|
@milleruntime, see the discussion on PR #1907 here. |
DomGarguilo
pushed a commit
to DomGarguilo/accumulo
that referenced
this pull request
Feb 10, 2021
This change renames reference to master in comments, variable names, constants, etc. to manager. In some deprecated classes whose purpose is to maintain compatibility until the next major release, the references were not renamed. * Change the constant defining the zookeeper dir where manager lock, tick, and goal state info are stored from masters to managers. * Add a utility to rename the existing masters dir in ZK from masters to managers. * Attempt renaming from SetGoalState, but also allow an admin to invoke directly if desired. fixes apache#1642
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change renames reference to master in comments, variable names,
constants, etc. to manager. In some deprecated classes whose purpose is
to maintain compatibility until the next major release, the references
were not renamed.
fixes #1642