Add option to disable encryption to AESCryptoService#2064
Merged
milleruntime merged 2 commits intoapache:mainfrom May 12, 2021
Merged
Add option to disable encryption to AESCryptoService#2064milleruntime merged 2 commits intoapache:mainfrom
milleruntime merged 2 commits intoapache:mainfrom
Conversation
Contributor
milleruntime
commented
Apr 30, 2021
milleruntime
commented
- Also add tests to CryptoTest
- Closes Read encrypted files with Encryption disabled #2000
ctubbsii
approved these changes
May 4, 2021
Member
ctubbsii
left a comment
ctubbsii
left a comment
There was a problem hiding this comment.
I think this change looks okay. It helps the user go from encryption to none if they were using the AESCryptoService.
core/src/main/java/org/apache/accumulo/core/spi/crypto/AESCryptoService.java
Outdated
Show resolved
Hide resolved
PircDef
approved these changes
May 7, 2021
* Also add tests to CryptoTest * Closes apache#2000
milleruntime
force-pushed
the
crypto-disable
branch
from
7c87136 to
d742508
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.