Skip to content

Conversation

@milleruntime
Copy link
Contributor

  • Add method to deprecated API to prevent errors
  • Add test to DeprecatedConstraintExtendTest

This should fix ShellServerIT

* Add method to deprecated API to prevent errors
* Add test to DeprecatedConstraintExtendTest
Copy link
Member

@ctubbsii ctubbsii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it fixes the test.

@milleruntime
Copy link
Contributor Author

@EdColeman I think this is all that needs to be done for the latest failures in ShellServerIT, it passes locally for me with this fix. But I am not sure if it covers everything you are looking at in #2070 and #2073

@milleruntime milleruntime merged commit 6094a53 into apache:main May 3, 2021
@milleruntime milleruntime deleted the constraint-fix branch May 3, 2021 21:13
@ctubbsii ctubbsii added this to the 2.1.0 milestone Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants