Add fromClassPath Method #2075
Merged
Add fromClassPath Method #2075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctubbsii
requested changes
May 5, 2021
Member
ctubbsii
left a comment
ctubbsii
left a comment
There was a problem hiding this comment.
Overall, this looks great to me, but it seems there's a spotbugs check that needs to be fixed first:
[ERROR] Medium: This web server request could be used by an attacker to expose internal services and filesystem.
[org.apache.accumulo.core.clientImpl.ClientInfoImpl, org.apache.accumulo.core.clientImpl.ClientContext$ClientBuilderImpl, org.apache.accumulo.core.clientImpl.ClientInfo, org.apache.accumulo.core.clientImpl.ClientInfoImpl]
At ClientInfoImpl.java:[line 127]
At ClientContext.java:[line 803]
At ClientInfo.java:[line 87]
At ClientInfoImpl.java:[line 47] URLCONNECTION_SSRF_FD
This commit contains changes that accepts URL paths to accumulo-client.properties
slackwinner
force-pushed
the
accumulo-fromClassPath
branch
from
e64d57f to
52fce35
Compare
milleruntime
reviewed
May 6, 2021
core/src/main/java/org/apache/accumulo/core/clientImpl/ClientInfoImpl.java
Show resolved
Hide resolved
ctubbsii
approved these changes
May 11, 2021
Manno15
pushed a commit
to Manno15/accumulo
that referenced
this pull request
May 12, 2021
This commit contains changes that accepts URL paths to accumulo-client.properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit contains introduces a fourth from() that accepts URL paths to accumulo-client.properties. This additional method would allow users to build an Accumulo client from the properties file embedded in the classpath.