Add optional extent to metadata update failure logs#2086
Merged
ctubbsii merged 2 commits intoapache:mainfrom May 11, 2021
Merged
Add optional extent to metadata update failure logs#2086ctubbsii merged 2 commits intoapache:mainfrom
ctubbsii merged 2 commits intoapache:mainfrom
Conversation
ctubbsii
requested changes
May 7, 2021
...ase/src/main/java/org/apache/accumulo/server/master/balancer/HostRegexTableLoadBalancer.java
Outdated
Show resolved
Hide resolved
server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java
Outdated
Show resolved
Hide resolved
server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java
Outdated
Show resolved
Hide resolved
ctubbsii
reviewed
May 10, 2021
server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java
Outdated
Show resolved
Hide resolved
server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java
Show resolved
Hide resolved
ctubbsii
approved these changes
May 11, 2021
Member
ctubbsii
left a comment
ctubbsii
left a comment
There was a problem hiding this comment.
Looks good to me, but waiting on build quality checks before merging.
Thanks for the PR @jschmidt10 . If you wish to be added as a contributor to https://accumulo.apache.org/people/ , please open a pull request to add yourself at https://github.com/apache/accumulo-website/edit/main/pages/people.md and leave a reference to apache/accumulo#2086 in your commit log.
If you intend to be a regular contributor to Accumulo projects, please consider subscribing to our developer mailing list (https://accumulo.apache.org/contact-us/) and introducing yourself. 😺
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This week we saw many "Failed to do close consistency check" errors. The log showed that the accumulo.metadata table had additional RFiles that were not present in the tserver's DatafileManager.datafileSizes map. We believe that this may have been due to a temporary network drop where a bulk importing tserver sent accumulo.metadata updates - the metadata updates were persisted but the bulk importing tserver's writer client did not receive a successful response.
We'd like to add some additional logging to MetadataTableUtil so that we can tie the failures back to particular tablets to see if these correlate.