PopulateMetadataTable Improvements#2118
Merged
Manno15 merged 4 commits intoapache:mainfrom Jun 3, 2021
Merged
Conversation
DomGarguilo
commented
May 27, 2021
...er/src/main/java/org/apache/accumulo/manager/tableOps/tableImport/PopulateMetadataTable.java
Outdated
Show resolved
Hide resolved
Manno15
approved these changes
May 27, 2021
Contributor
Manno15
left a comment
Manno15
left a comment
There was a problem hiding this comment.
Everything else looks fine.
keith-turner
reviewed
Jun 3, 2021
...er/src/main/java/org/apache/accumulo/manager/tableOps/tableImport/PopulateMetadataTable.java
Outdated
Show resolved
Hide resolved
keith-turner
approved these changes
Jun 3, 2021
ctubbsii
approved these changes
Jun 3, 2021
Member
ctubbsii
left a comment
ctubbsii
left a comment
There was a problem hiding this comment.
@DomGarguilo We were both fixing the conflict at the same time. You beat me to it, though :) This can be merged once the QA checks pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1091
Improvements include:
currentRowafter each mutation