Test converting client props to ConditionalWriterConfig#2135
Merged
jmark99 merged 3 commits intoapache:mainfrom Jun 2, 2021
Merged
Test converting client props to ConditionalWriterConfig#2135jmark99 merged 3 commits intoapache:mainfrom
jmark99 merged 3 commits intoapache:mainfrom
Conversation
Created two unit tests for the conversion of client properties to ConditionalWriterConfig. One using default values and another using modified values. Refactored getConditionalWriterConfig into two methods to facilitate unit testing.
DomGarguilo
reviewed
Jun 2, 2021
core/src/test/java/org/apache/accumulo/core/clientImpl/ClientContextTest.java
Outdated
Show resolved
Hide resolved
Update comment to reference correct property (CONDITIONAL_WRITER_TIMEOUT_MAX) Co-authored-by: Dom G. <47725857+DomGarguilo@users.noreply.github.com>
Update name of Client Property used in a comment.
Contributor
Author
|
@DomGarguilo thanks for the catch on the comment! |
EdColeman
approved these changes
Jun 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created two unit tests for the conversion of client properties to ConditionalWriterConfig. One using default values and another using modified values.
Refactored getConditionalWriterConfig into two methods to facilitate unit testing.
Closes #2131