Make ExternalCompactionIT faster by reusing MiniAccumuloCluster #2167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified the test to use a different parent class that uses a shared MiniAccumuloCluster for the different tests. Also reduced the time based configuration properties in an attempt to make things faster. Closes apache#2159
milleruntime
approved these changes
Jun 15, 2021
Contributor
milleruntime
left a comment
milleruntime
left a comment
There was a problem hiding this comment.
Assuming it is faster, looks good. I thought you may be able to save time if you don't care about cleaning up tables between tests. Another thing to consider is the new reuseForks behavior in our build. This seems like a test where we may not want to reuse forks.
ctubbsii
reviewed
Jun 15, 2021
test/src/main/java/org/apache/accumulo/test/ExternalCompactionIT.java
Outdated
Show resolved
Hide resolved
ctubbsii
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the test to use a different parent class that uses a
shared MiniAccumuloCluster for the different tests. Also reduced
the time based configuration properties in an attempt to make
things faster.
Closes #2159