fixes #2111 adds unit test for external compaction metadata validation#2309
Merged
keith-turner merged 11 commits intoapache:mainfrom Oct 12, 2021
Merged
Conversation
Contributor
|
FYI the phrase "sanity check" currently gets flagged by the new Apache CLC - Conscious Language Checker tool https://clc.diversity.apache.org/ |
ctubbsii
reviewed
Oct 11, 2021
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactableImpl.java
Outdated
Show resolved
Hide resolved
…t/CompactableImpl.java Fix javadoc new paragraph
ctubbsii
reviewed
Oct 11, 2021
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactableImpl.java
Outdated
Show resolved
Hide resolved
…t/CompactableImpl.java
ctubbsii
reviewed
Oct 11, 2021
core/src/main/java/org/apache/accumulo/core/metadata/schema/ExternalCompactionMetadata.java
Outdated
Show resolved
Hide resolved
Contributor
Author
@milleruntime I updated the wording for those comments in 72e49b9 |
Manno15
reviewed
Oct 12, 2021
core/src/main/java/org/apache/accumulo/core/metadata/schema/ExternalCompactionMetadata.java
Show resolved
Hide resolved
…ternalCompactionMetadata.java Co-authored-by: Jeffrey Manno <jeffreymanno15@gmail.com>
ctubbsii
reviewed
Oct 12, 2021
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactableImpl.java
Outdated
Show resolved
Hide resolved
…t/CompactableImpl.java
ctubbsii
approved these changes
Oct 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.