Add to Upgrader9to10 javadoc. Closes #1922#2426
Conversation
…de/Upgrader9to10.java Co-authored-by: Dom G. <domgarguilo@apache.org>
Thanks for looking it over! |
ctubbsii
left a comment
ctubbsii
left a comment
There was a problem hiding this comment.
The class level documentation for these upgraders are probably best written as a list of expected changes that the class performs as part of its upgrade tasks. The specific methods added or implementation details or pull request references that resulted in the current code aren't useful for helping the reader of this javadoc understand what they can expect this class to do to their cluster when it upgrades it, and can either be removed, or relocated to their specific implementation methods.
ctubbsii
left a comment
ctubbsii
left a comment
There was a problem hiding this comment.
This is fine. I made one comment about some stuff that could have stayed at the class level, but it's also fine if it moves. I don't think it matters much.
| * | ||
| * Sorted recovery was updated to use RFiles instead of map files. So to prevent issues during | ||
| * tablet recovery, remove the old temporary map files and resort using RFiles. This is done in | ||
| * {@link #dropSortedMapWALFiles(ServerContext)}. For more information see the following issues: | ||
| * <a href="https://github.com/apache/accumulo/issues/2117">#2117</a> and | ||
| * <a href="https://github.com/apache/accumulo/issues/2179">#2179</a> |
There was a problem hiding this comment.
This was probably fine to leave here, because it described the overall behavior of the Upgrader class.
3 participants
No description provided.