checks for nested error in AUEH #2530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctubbsii
reviewed
Feb 26, 2022
Member
There was a problem hiding this comment.
Looks good. My only suggestion is slight changes to the test.
EDIT: Please update the subject line or git commit log to explicitly spell out AccumuloUncaughtExceptionHandler when this is eventually merged. I didn't know what AEUH meant, and I don't think it should require looking at the diff in order to understand the log message. Usually, it's the other way around, the log message helps explain what the changes are doing.
...rc/test/java/org/apache/accumulo/core/util/threads/AccumuloUncaughtExceptionHandlerTest.java
Show resolved
Hide resolved
dlmarion
approved these changes
Feb 28, 2022
Contributor
dlmarion
left a comment
dlmarion
left a comment
There was a problem hiding this comment.
Looks good. Agree with Christopher's comments.
keith-turner
commented
Feb 28, 2022
core/src/main/java/org/apache/accumulo/core/util/threads/AccumuloUncaughtExceptionHandler.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.