Sync FateIT.getTxStatus #2550
Merged
Sync FateIT.getTxStatus #2550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix FateIT stability issues by ensuring the ZooKeeper client is sync'd to the quorum state when verifying the transaction status. This fixes apache#2474 and supersedes apache#2546
dlmarion
approved these changes
Mar 8, 2022
Contributor
dlmarion
left a comment
dlmarion
left a comment
There was a problem hiding this comment.
Looks good, I missed the fact that ZooReader.sync() exists.
ctubbsii
added a commit
to ctubbsii/accumulo
that referenced
this pull request
Nov 27, 2024
Related to apache#2474 and apache#2550. The sync fix in apache#2550 helped ensure that the ZooKeeper client had the updated status, it is still possible for the node to be deleted before the SUCCESSFUL transaction status is observed. This change makes FateIT more stable by accepting that as a valid possible outcome, and no longer fails when that happens.
ctubbsii
added a commit
that referenced
this pull request
Nov 27, 2024
Related to #2474 and #2550. The sync fix in #2550 helped ensure that the ZooKeeper client had the updated status, it is still possible for the node to be deleted before the SUCCESSFUL transaction status is observed. This change makes FateIT more stable by accepting that as a valid possible outcome, and no longer fails when that happens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix FateIT stability issues by ensuring the ZooKeeper client is sync'd
to the quorum state when verifying the transaction status.
This fixes #2474 and supersedes #2546