Fix Fate print command and improve ShellServerIT test #2755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Test provided by millerruntime, modified to add cluster accumulo.properties - modified logic for fate filters
milleruntime
reviewed
Jun 6, 2022
| final String table = getUniqueNames(1)[0]; | ||
|
|
||
| System.setProperty("accumulo.properties", | ||
| "file://" + getCluster().getConfig().getAccumuloPropsFile().getCanonicalPath()); |
milleruntime
reviewed
Jun 6, 2022
- modified filter logic - expanded IT test - modified unit test, command parsing didn't match IT results
Contributor
|
I think this could be marked ready for review. There are some white space changes that could be dropped and the logic is confusing but if the test is passing then that is the important part to fix #2754. This PR is definitely closer to being merged than #2780, which is just an updated version of 2215. |
EdColeman
changed the title
test/src/main/java/org/apache/accumulo/test/shell/ShellServerIT.java
Outdated
Show resolved
Hide resolved
milleruntime
approved these changes
Jun 23, 2022
Manno15
approved these changes
Jun 25, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more for discussion of #2754, the the fate -print issue. It seems that the code was filtering the transaction.
Comparing the logic in main and in #2215, the logic seems the same, so not sure what is going on.
Also, the original logic seemed correct, but rather than the negative / skip logic that was used, this code flips that. Not sure this is a final solution - but maybe it help points to the issue.