Skip to content

Conversation

@DomGarguilo
Copy link
Member

@DomGarguilo DomGarguilo commented Jun 23, 2022

This PR changes the tables in bulkImport.js to DataTables. These changes can be viewed in the monitor at /bulkImports.

Here is the page on main:
BulkImportOldTables

Here is the page on this branch:
BulkImportDataTables

Note: I hardcoded data to be present at the REST endpoint used to gather data for the "Bulk Imports" table.

The various info and features that are standard with DataTables (such as the search bar and paging) can be removed if anyone thinks that is a good idea.

@dlmarion
Copy link
Contributor

Is there a way to make the Age column in the top table wider such that it only uses 1 line?

@DomGarguilo DomGarguilo requested a review from milleruntime June 23, 2022 19:22
@DomGarguilo
Copy link
Member Author

Is there a way to make the Age column in the top table wider such that it only uses 1 line?

Yea, it looks like you can designate the widths. I've given the columns widths of 20%, 60%, 20% respectively which looks like this:
image

I might mess around with exact width percentages some more but it looks like it can be changed, @dlmarion.

Maybe the state column could be the shortest since we know those will only ever be as long as the longest BulkImportState, so maybe around 15% width or so. But the directory columns should probably be pretty wide too right?

@DomGarguilo
Copy link
Member Author

Is there a way to make the Age column in the top table wider such that it only uses 1 line?

Addressed in 5633444

@dlmarion
Copy link
Contributor

maybe 40 / 40 / 20?

@DomGarguilo
Copy link
Member Author

maybe 40 / 40 / 20?

40 / 45 / 15 looks like:
image

@dlmarion
Copy link
Contributor

dlmarion commented Jun 23, 2022

yeah, that looks ok too

<tbody></tbody>
</table>
</div>
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we try to keep a newline at the end of each file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in fd76f0e

@DomGarguilo DomGarguilo merged commit 44cefe8 into apache:main Jun 27, 2022
@DomGarguilo DomGarguilo deleted the bulkImportDataTables branch June 27, 2022 17:15
@ctubbsii ctubbsii added this to the 2.1.0 milestone Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants