-
Notifications
You must be signed in to change notification settings - Fork 474
Convert tables in bulkImport.js to DataTables #2784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Is there a way to make the |
Yea, it looks like you can designate the widths. I've given the columns widths of 20%, 60%, 20% respectively which looks like this: I might mess around with exact width percentages some more but it looks like it can be changed, @dlmarion. Maybe the state column could be the shortest since we know those will only ever be as long as the longest |
Addressed in 5633444 |
|
maybe 40 / 40 / 20? |
|
yeah, that looks ok too |
| <tbody></tbody> | ||
| </table> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we try to keep a newline at the end of each file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in fd76f0e


This PR changes the tables in bulkImport.js to DataTables. These changes can be viewed in the monitor at /bulkImports.
Here is the page on main:

Here is the page on this branch:

Note: I hardcoded data to be present at the REST endpoint used to gather data for the "Bulk Imports" table.
The various info and features that are standard with DataTables (such as the search bar and paging) can be removed if anyone thinks that is a good idea.