Skip to content

ACCUMULO-4702 Removed Beta Guava dependencies#299

Merged
milleruntime merged 1 commit intoapache:1.7from
milleruntime:ACCUMULO-4702
Sep 25, 2017
Merged

ACCUMULO-4702 Removed Beta Guava dependencies#299
milleruntime merged 1 commit intoapache:1.7from
milleruntime:ACCUMULO-4702

Conversation

@milleruntime
Copy link
Copy Markdown
Contributor

@milleruntime milleruntime commented Sep 14, 2017

Created code to remove Guava dependencies which are still beta in release 23:
com.google.common.util.concurrent.Uninterruptibles
com.google.common.io.Files
com.google.common.hash.HashCode;
com.google.common.hash.HashFunction;
com.google.common.hash.Hashing;

keith-turner
keith-turner reviewed Sep 14, 2017
View reviewed changes
fate/src/main/java/org/apache/accumulo/fate/util/UtilWaitThread.java
* @author Anthony Zana
* @since 10.0
*/
public static void sleepUninterruptibly(long sleepFor, TimeUnit unit) {
Copy link
Copy Markdown
Contributor

@keith-turner keith-turner Sep 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be nice to put all copied guava code into one package. Not sure if this is possible.

@milleruntime
Copy link
Copy Markdown
Contributor Author

milleruntime commented Sep 15, 2017

This work for 1.7 was pretty minor but 1.8 has a lot more reliance on Guava and uses a LOT of beta code... and I am not sure its worth it to copy in/replace all Beta code in 1.8.

@milleruntime
Copy link
Copy Markdown
Contributor Author

milleruntime commented Sep 15, 2017 •
edited
Loading

Concerns for 1.8 (I will put them here since this may change the solution for all versions):
AbstractHashSampler.java:[89,31] md5() in com.google.common.hash.Hashing has been deprecated
AbstractHashSampler.java:[92,31] sha1() in com.google.common.hash.Hashing has been deprecated
com.google.common.hash.Hasher, which is annotated with Beta At DataoutputHasher.java
Use of class com.google.common.util.concurrent.RateLimiter, which is annotated with Beta At GuavaRateLimiter.java

@milleruntime
Copy link
Copy Markdown
Contributor Author

milleruntime commented Sep 25, 2017

If there are no objections for this solution to 1.7 I will merge this today. There will need to be follow on work for 1.8 and master.

@milleruntime milleruntime merged commit 2962878 into apache:1.7 Sep 25, 2017
asfgit pushed a commit that referenced this pull request Sep 25, 2017
@milleruntime
ACCUMULO-4702 Merged up Guava changes from #299
6e2e2e7
@milleruntime milleruntime deleted the ACCUMULO-4702 branch December 8, 2017 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keith-turner keith-turner keith-turner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@milleruntime @keith-turner