Make use of GitHub Actions environment files #3024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set-output was previously used to create the IT matrix, but it is now deprecated. So, this change makes use of the environment files instead. See https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#environment-files
ctubbsii
force-pushed
the
update-github-actions
branch
from
3ac3345 to
9908f6e
Compare
EdColeman
approved these changes
Oct 14, 2022
Contributor
EdColeman
left a comment
EdColeman
left a comment
There was a problem hiding this comment.
Changes LGTM - unless the results of the full test run revel any issues.
Member
Author
|
I'm troubleshooting an error that seems to be a data type issue: It looks like GitHub is parsing environment variables as String types, and I can't seem to convert it to a "Mapping" type. |
Member
Author
|
Ignore my previous observations. I forgot to update the job output mapping to reflect the new step output name. I'm testing now, but I think the current bits will work. |
Member
Author
|
Okay, got it working. Apparently, you're not supposed to quote the output value, but leave the raw JSON... which is weird, because it makes an invalid environment variable assignment in a shell script... but apparently that's what it wants. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set-output was previously used to create the IT matrix, but it is now deprecated. So, this change makes use of the environment files instead.
See https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#environment-files