test improvements from PR #1333 and check-style clean up#3063
Merged
ctubbsii merged 3 commits intoapache:2.1from Nov 3, 2022
Merged
test improvements from PR #1333 and check-style clean up#3063ctubbsii merged 3 commits intoapache:2.1from
ctubbsii merged 3 commits intoapache:2.1from
Conversation
ctubbsii
reviewed
Nov 2, 2022
Member
ctubbsii
left a comment
ctubbsii
left a comment
There was a problem hiding this comment.
The test changes seem fine. I don't see a compelling reason to put these in a 2.1 bugfix release, though.
The only substantive change is the check for head != null before calling cb.compareTo(head), for which I have reservations below:
core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/lru/CachedBlockQueue.java
Outdated
Show resolved
Hide resolved
keith-turner
reviewed
Nov 2, 2022
core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/lru/CachedBlockQueue.java
Show resolved
Hide resolved
core/src/test/java/org/apache/accumulo/core/file/blockfile/cache/TestCachedBlockQueue.java
Show resolved
Hide resolved
core/src/test/java/org/apache/accumulo/core/file/blockfile/cache/TestCachedBlockQueue.java
Show resolved
Hide resolved
DomGarguilo
reviewed
Nov 2, 2022
core/src/test/java/org/apache/accumulo/core/file/blockfile/cache/TestCachedBlockQueue.java
Outdated
Show resolved
Hide resolved
keith-turner
approved these changes
Nov 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1333 had some significant test improvements. Although there was a lot of commentary on the original ticket it did not seem to reach a conclusion. This PR pulls the test improvements and fixes some check style errors but does not change the functionality of the code as proposed in #13333 - those can be evaluated or abandoned separately from these changes,