Add id info to config check utility

[EdColeman]

The ConfigCheckUtil.validate function logs issues with properties, but does not include an id to help find where the issue is occurring. This PR adds the namespace or table id - or if an id is not provided, it assumes the property is from the site configuration.

This was noticed after upgrading a 2.1 instance with replication configured. PR #3137 is independent of these changes, but this PR does provide additional information once upgrades are possible with PR #3137

Before the changes, the logs looks like:

2022-12-27T17:55:57,477 [conf.ConfigCheckUtil] WARN : BAD CONFIG unrecognized property key (replication.name)
2022-12-27T17:55:57,477 [conf.ConfigCheckUtil] WARN : BAD CONFIG unrecognized property key (replication.peer.password.peer1)
2022-12-27T17:55:57,477 [conf.ConfigCheckUtil] WARN : BAD CONFIG unrecognized property key (replication.peer.peer1)
2022-12-27T17:55:57,477 [conf.ConfigCheckUtil] WARN : BAD CONFIG unrecognized property key (replication.peer.user.peer1)
2022-12-27T17:55:57,485 [conf.ConfigCheckUtil] WARN : BAD CONFIG unrecognized property key (replication.name)
2022-12-27T17:55:57,485 [conf.ConfigCheckUtil] WARN : BAD CONFIG unrecognized property key (replication.peer.password.peer1)
2022-12-27T17:55:57,485 [conf.ConfigCheckUtil] WARN : BAD CONFIG unrecognized property key (replication.peer.peer1)
2022-12-27T17:55:57,485 [conf.ConfigCheckUtil] WARN : BAD CONFIG unrecognized property key (replication.peer.user.peer1)

With these changes:

2022-12-27T22:15:30,945 [conf.ConfigCheckUtil] WARN : BAD CONFIG unrecognized property key (replication.name) for site

2022-12-27T18:49:40,286 [conf.ConfigCheckUtil] WARN : BAD CONFIG unrecognized property key (replication.name) for +accumulo
2022-12-27T18:49:40,286 [conf.ConfigCheckUtil] WARN : BAD CONFIG unrecognized property key (replication.peer.password.peer1) for +accumulo
2022-12-27T18:49:40,286 [conf.ConfigCheckUtil] WARN : BAD CONFIG unrecognized property key (replication.peer.peer1) for +accumulo
2022-12-27T18:49:40,286 [conf.ConfigCheckUtil] WARN : BAD CONFIG unrecognized property key (replication.peer.user.peer1) for +accumulo
2022-12-27T18:49:40,293 [conf.ConfigCheckUtil] WARN : BAD CONFIG unrecognized property key (replication.name) for +r
2022-12-27T18:49:40,293 [conf.ConfigCheckUtil] WARN : BAD CONFIG unrecognized property key (replication.peer.password.peer1) for +r
2022-12-27T18:49:40,293 [conf.ConfigCheckUtil] WARN : BAD CONFIG unrecognized property key (replication.peer.peer1) for +r
2022-12-27T18:49:40,293 [conf.ConfigCheckUtil] WARN : BAD CONFIG unrecognized property key (replication.peer.user.peer1) for +r
2022-12-27T18:49:40,299 [balancer.TableLoadBalancer] INFO : Loaded class org.apache.accumulo.core.spi.balancer.SimpleLoadBalancer for table +r

[EdColeman]

A question before merging - When passing the ID, if it is not namespace or table, then I pass null and assume that means system config for the log statement. General question is that correct or would something other than system be better displayed in the log statement.

[dlmarion]

So, given the levels of configuration (default, system, site, namespace, table), the default configuration can't be invalid. Is there a way to differentiate between the system and site configs?

Edit: Looking at the code, you might need to call ConfigCheckUtil.validate in the SystemConfiguration constructor passing in getSnapshot().

[EdColeman]

So, given the levels of configuration (default, system, site, namespace, table)

I don't think so without major changes (and maybe not then) - but in this context I think that site, namespace and table are the only ones that matter - that is, they are the only ones users can control. Default and system are our responsibility and need to be correct in the code - this change is to log the id's so that users can see where BAD CONFIG errors are occurring.

[EdColeman]

The code could be modified to pass a string instead of Id to allow more flexibility,

[ctubbsii]

Since these are strings, I think I would have preferred something like:

ConfigCheckUtil.validate(conf, "Namespace id: " + namespaceId);

So we know it's a namespace and not a table ID. Same with the table IDs.