Move Gson ByteArrayToBase64TypeAdapter to its own utility class #3285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BulkSerialize had a Gson adapter to serialize byte arrays to Base64 encoding that can be re-used by other areas in the code. Also update the uses of the base 64 Gson object to be static and re-used as the objects are thread-safe so can be created just one time.
DomGarguilo
reviewed
Apr 7, 2023
core/src/test/java/org/apache/accumulo/core/util/ByteArrayToBase64TypeAdapterTest.java
Outdated
Show resolved
Hide resolved
keith-turner
approved these changes
Apr 7, 2023
core/src/main/java/org/apache/accumulo/core/util/ByteArrayToBase64TypeAdapter.java
Show resolved
Hide resolved
cshannon
added a commit
that referenced
this pull request
Apr 8, 2023
Minor follow up to #3285 to move the base 64 serializer to a json subpackage under util
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BulkSerialize had a Gson adapter to serialize byte arrays to Base64 encoding that can be re-used by other areas in the code. Also update the uses of the base 64 Gson object to be static and re-used as the objects are thread-safe so can be created just one time.
I noticed this when working on serializing ranges as part of the updates for #1327 and this PR will be the first part of my PR for that task but this was something that could be done separately and pulled out into its own PR.