removes vestigial cache clear in bulk import#3339
Merged
keith-turner merged 1 commit intoapache:mainfrom Apr 25, 2023
Merged
Conversation
While working on apache#3337 code that cleared the table id cache for no apparent reason was found. Investigation indicates that the cache clear used to happen before a cache read. The cache read was removed, but the cache clear was left behind. This commit removes the cache clear. The following commit shows the old clear and then read. https://github.com/apache/accumulo/blob/ff8c875b83880c1fde3562f1280d6e20bc1ac682/server/master/src/main/java/org/apache/accumulo/master/tableOps/bulkVer2/PrepBulkImport.java#L89-L95
Contributor
|
LGTM. |
dlmarion
approved these changes
Apr 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #3337 code that cleared the table id cache for no apparent reason was found. Investigation indicates that the cache clear used to happen before a cache read. The cache read was removed, but the cache clear was left behind. This commit removes the cache clear. The following commit shows the old clear and then read.
accumulo/server/master/src/main/java/org/apache/accumulo/master/tableOps/bulkVer2/PrepBulkImport.java
Lines 89 to 95 in ff8c875