More build updates to reduce warnings #3426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce warnings at the end of the build from using Maven 3.9.2 by updating several plugins whose versions are specified in the parent POM to the latest, which resolves the warnings from Maven. Specifically, update maven-resources-plugin, maven-compiler-plugin, exec-maven-plugin, apilyzer-maven-plugin, maven-dependency-plugin, and maven-enforcer-plugin. Update some dependency declarations, based on new detections from latest version of maven-dependency-plugin (specifically, zookeeper-jute in minicluster and libthrift in the monitor). Updating exec-maven-plugin required addressing apache#3033 with a workaround, and testing the script added for that workaround caught some additional shellcheck issues in the assembly module's cluster management scripts (unreachable redundant exit command) and generate-thrift.sh (unquoted path variable). So those fixes are included here as well. This fixes apache#3033.
Member
Author
|
Updating apilyzer required me to actually update that project and release a new version of it, which I hadn't done since 2017. |
EdColeman
approved these changes
May 25, 2023
asfgit
pushed a commit
that referenced
this pull request
Aug 14, 2023
Reduce warnings at the end of the build from using Maven 3.9.2 by updating several plugins whose versions are specified in the parent POM to the latest, which resolves the warnings from Maven. Specifically, update maven-resources-plugin, maven-compiler-plugin, exec-maven-plugin, apilyzer-maven-plugin, maven-dependency-plugin, and maven-enforcer-plugin. Update some dependency declarations, based on new detections from latest version of maven-dependency-plugin (specifically, zookeeper-jute in minicluster and libthrift in the monitor). Updating exec-maven-plugin required addressing #3033 with a workaround, and testing the script added for that workaround caught some additional shellcheck issues in the assembly module's cluster management scripts (unreachable redundant exit command) and generate-thrift.sh (unquoted path variable). So those fixes are included here as well. This fixes #3033.
Member
Author
|
Backported to 2.1.2 as 4f5d358 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce warnings at the end of the build from using Maven 3.9.2 by updating several plugins whose versions are specified in the parent POM to the latest, which resolves the warnings from Maven. Specifically, update maven-resources-plugin, maven-compiler-plugin, exec-maven-plugin, apilyzer-maven-plugin, maven-dependency-plugin, and maven-enforcer-plugin.
Update some dependency declarations, based on new detections from latest version of maven-dependency-plugin (specifically, zookeeper-jute in minicluster and libthrift in the monitor).
Updating exec-maven-plugin required addressing #3033 with a workaround, and testing the script added for that workaround caught some additional shellcheck issues in the assembly module's cluster management scripts (unreachable redundant exit command) and generate-thrift.sh (unquoted path variable). So those fixes are included here as well.
This fixes #3033.