Make sure existing file path is used for metadata updates

[cshannon]

This fixes instances identified in #3417 where updates to existing files in the metadata table were using the normalized path by mistake and not the existing path.

[cshannon]

@keith-turner - This should fix the issues you identified in the other PR. Besides the fix MetadataTableUtil in finishSplit(), two spots in ManagerMetadataUtil will now use the overloaded putFile() method that takes a StoredTabletFile and uses getMetaUpdateDeleteText().

accumulo/server/base/src/main/java/org/apache/accumulo/server/util/ManagerMetadataUtil.java

Line 97 in 969fc52

datafileSizes.forEach(tablet::putFile);

accumulo/server/base/src/main/java/org/apache/accumulo/server/util/ManagerMetadataUtil.java

Line 205 in 969fc52

tablet.putFile(path.orElseThrow(), size);

Do you think we should try and add the IT you were talking about as part of this or create a follow on?

[cshannon]

Sunny IT tests passed and I kicked off a full IT build.

Also, I just had a thought that maybe as part of this PR (which only applies in the 2.1 branch where there is still an inheritance relationship) in StoredTabletFile we should actually override

accumulo/core/src/main/java/org/apache/accumulo/core/metadata/TabletFile.java

Line 109 in 969fc52

public String getMetaInsert() {

and

accumulo/core/src/main/java/org/apache/accumulo/core/metadata/TabletFile.java

Line 109 in 969fc52

public String getMetaInsert() {

and either throw a new UnsupportedOperationException or return the metadataEntry (instead of the normalized path) so we prevent any errors in the future so the normalized path is never used. In #3417 this of course wouldn't be necessary anymore.

[cshannon]

Full IT passed. As commented on #3435, this PR fixes the test there.