moves hosting request processing from tserver to manager#3437
Merged
keith-turner merged 4 commits intoapache:elasticityfrom May 30, 2023
Merged
moves hosting request processing from tserver to manager#3437keith-turner merged 4 commits intoapache:elasticityfrom
keith-turner merged 4 commits intoapache:elasticityfrom
Conversation
Processing of hosting request was moved from the tserver to manager so that the tablet group watcher could be notified. This considerably reduces the delay in getting an ondemand tablet hosted. Introduced a cache to avoid reprocessing hosting request for the same tablet in a short time period. Modified the update of the hosting request column to use a conditional mutation. This avoids a metadata read before write (the read is now done by the mutation conditions) and avoids race conditions. Moving the hosting request to the manager could introduce scaling problems, however the cache can help with this. The reduced latency for hosting ondemand tablet is needed, so if there are scaling problems a soluting will need to be found that has low latency for hosting.
dlmarion
reviewed
May 30, 2023
server/manager/src/main/java/org/apache/accumulo/manager/ManagerClientServiceHandler.java
Outdated
Show resolved
Hide resolved
dlmarion
approved these changes
May 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Processing of hosting request was moved from the tserver to manager so that the tablet group watcher could be notified. This considerably reduces the delay in getting an ondemand tablet hosted.
Introduced a cache to avoid reprocessing hosting request for the same tablet in a short time period.
Modified the update of the hosting request column to use a conditional mutation. This avoids a metadata read before write (the read is now done by the mutation conditions) and avoids race conditions.
Moving the hosting request to the manager could introduce scaling problems, however the cache can help with this. The reduced latency for hosting ondemand tablet is needed, so if there are scaling problems a solution will need to be found that has low latency for hosting.