Remove more deprecations for 3.0#3456
Merged
Merged
Conversation
* Remove references to deprecated compaction strategies that don't exist
* Relocate unfortunately named `ConfigurableCompactionStrategy`, which
existed solely to support the shell for user-initiated compactions,
into two separate classes in accumulo-core.jar, as
`ShellCompactCommandConfigurer` and `ShellCompactCommandSelector`
1. Split into two classes to make it clear how they map to the SPI
interfaces and to avoid confusing overloaded init methods with
two different InitParameters classes that have the same simple name
2. Put in accumulo-core.jar so it's on the classpath for servers
that do compaction and the shell, so we can get the class name
without using a String literal, which is fragile
3. Avoid use of the "CompactionStrategy" naming, because that is the
name of the deprecated, and now removed, interface
4. Update corresponding tests
* Remove check for deprecated accumulo-site.xml, which was replaced in
2.1. 3.x requires upgrade from at least 2.1, so that either will have
already been updated in 2.1, or it will never have existed in 3.x.
Also remove related config converter utilities.
* Remove randomizeVolumes from the admin command, which was previously
made a noop and deprecated
* Remove unused accumulo-site.xml test resource
* Remove deprecated FateCommand from the shell
* Remove noop debug option from shell command-line that did nothing
because its functionality has been replaced by the ability to
dynamically configure log4j2 logging in 2.x
* Remove deprecated gc.trash.ignore (`GC_TRASH_IGNORE`) property, as
follow-on to apache#3436; this includes removing a test that's no longer
possible to succeed, since it's no longer possible to configure
Accumulo to ignore Hadoop's trash settings; some comments were cleaned
up in the remaining tests
dlmarion
approved these changes
Jun 7, 2023
Contributor
dlmarion
left a comment
dlmarion
left a comment
There was a problem hiding this comment.
The empty test feels odd, but I understand why it's there.
dlmarion
approved these changes
Jun 7, 2023
Contributor
dlmarion
left a comment
dlmarion
left a comment
There was a problem hiding this comment.
The empty test feels odd, but I understand why it's there.
Member
Author
Yeah, I don't like that either. |
asfgit
pushed a commit
that referenced
this pull request
Jun 7, 2023
As follow-up to #3456, remove the broken test in `ShellServerIT.testFateCommandWithSlowCompaction()` since the command it is testing was removed by that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConfigurableCompactionStrategy, which existed solely to support the shell for user-initiated compactions, into two separate classes in accumulo-core.jar, asShellCompactCommandConfigurerandShellCompactCommandSelectorGC_TRASH_IGNORE) property, as follow-on to Deprecate GC_TRASH_IGNORE, add tests to confirm Trash works #3436; this includes removing a test that's no longer possible to succeed, since it's no longer possible to configure Accumulo to ignore Hadoop's trash settings; some comments were cleaned up in the remaining tests