Replace ConcurrentHashMap with Caffine cache for configs#3599
Merged
EdColeman merged 1 commit intoapache:2.1from Jul 20, 2023
Merged
Conversation
Using a cache instead of a map to ensures that configs are cleaned up on deletions. The issues was rasied in PR apache#3588
dlmarion
approved these changes
Jul 19, 2023
keith-turner
approved these changes
Jul 20, 2023
| this.systemConfig = memoize(() -> new SystemConfiguration(context, | ||
| SystemPropKey.of(context.getInstanceID()), siteConfig)); | ||
| tableParentConfigs = | ||
| Caffeine.newBuilder().expireAfterAccess(CACHE_EXPIRATION_HRS, TimeUnit.HOURS).build(); |
Contributor
There was a problem hiding this comment.
I was wondering if adding a weigher would make sense. Looking at the caffine docs the weight is only acquired when something is added to the cache. So it would not really handle the case of configuration growing in size (like a user adds a large prop after its in the cache). So a weigher probably does not makes sense for this case because Configuration objects have a dynamic size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using a cache instead of a map to ensure that configs are eventually cleaned up on deletions. The issue was raised in PR #3588