ACCUMULO-4780 Add overflow check to seq num in CommitSession#360
Closed
jmark99 wants to merge 1 commit intoapache:1.7from
jmark99:ACCUMULO-4780
Closed
ACCUMULO-4780 Add overflow check to seq num in CommitSession#360jmark99 wants to merge 1 commit intoapache:1.7from jmark99:ACCUMULO-4780
jmark99 wants to merge 1 commit intoapache:1.7from
jmark99:ACCUMULO-4780
Conversation
Add overflow check to sequence number in CommitSession. Ticket suggested adding overflow check to sequence number or converting to long. This PR converted the sequence number from and int to long to prevent fear of future overflow. The change propagated to several other files that made use of or called methods that utilized the sequence number. Modified the various files and then re-ran tests and integration tests to verify nothing had broken. All tests passes.
Contributor
Author
|
The Travis build indicates failure after running for almost 7 hours, but when looking at the log output it indicates success. Any thoughts on what happened? |
Member
|
I saw that. It makes no sense. The Travis log shows a successful 21 minute build. I think the problem is with Travis and delays starting the build and problems with their time tracking. |
Contributor
Author
|
Thanks! I assumed there was some Travis issue, just not sure what. |
Member
|
They had a message about unusual backlog and delays on container-based infrastructure. My guess is that this is related. I restarted the build to see if anything changed. |
Contributor
Author
|
Appreciate it! |
keith-turner
approved these changes
Jan 17, 2018
Contributor
keith-turner
left a comment
keith-turner
left a comment
There was a problem hiding this comment.
This looks good @jmark99
I will merge it
Contributor
Author
|
Thanks, @keith-turner |
keith-turner
pushed a commit
that referenced
this pull request
Jan 17, 2018
Add overflow check to sequence number in CommitSession. Ticket suggested adding overflow check to sequence number or converting to long. This PR converted the sequence number from and int to long to prevent fear of future overflow. The change propagated to several other files that made use of or called methods that utilized the sequence number. Modified the various files and then re-ran tests and integration tests to verify nothing had broken. All tests passes.
Contributor
|
Merge in d99592c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ACCUMULO-4780 Add overflow check to sequence number in CommitSession
Ticket suggested adding overflow check to sequence number or converting to long.
This PR converted the sequence number from an int to long to prevent fear of future
overflow. The change propagated to several other files that made use of or called
methods that utilized the sequence number.
Updated the affected files and re-ran uni and integration (sunnyday) tests to verify all tests still passed. All tests still passed.