Skip to content

Always use retry backoff in ZooReader(Writer) #3720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ctubbsii merged 3 commits into from
Aug 24, 2023
+11 −2
Merged

Always use retry backoff in ZooReader(Writer) #3720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
50a47f8
Always use retry backoff in ZooReader(Writer)
ctubbsii Aug 24, 2023
5f87c11
Fix test
ctubbsii Aug 24, 2023
023415a
Add exception info to retry log message
ctubbsii Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions core/src/main/java/org/apache/accumulo/core/fate/zookeeper/ZooReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,12 @@ protected <R> R retryLoopMutator(ZKFunctionMutator<R> zkf,
try {
return zkf.apply(getZooKeeper());
} catch (KeeperException e) {
if (alwaysRetryCondition.test(e) || useRetryForTransient(retries, e)) {
if (alwaysRetryCondition.test(e)) {
retries.waitForNextAttempt(log,
Comment thread
keith-turner marked this conversation as resolved.
"attempting to communicate with zookeeper after exception that always requires retry: "
+ e.getMessage());
continue;
} else if (useRetryForTransient(retries, e)) {
continue;
}
throw e;
Expand All @@ -201,7 +206,8 @@ private static boolean useRetryForTransient(Retry retries, KeeperException e)
log.warn("Saw (possibly) transient exception communicating with ZooKeeper", e);
if (retries.canRetry()) {
retries.useRetry();
retries.waitForNextAttempt(log, "attempting to communicate with zookeeper after exception");
retries.waitForNextAttempt(log,
"attempting to communicate with zookeeper after exception: " + e.getMessage());
return true;
}
log.error("Retry attempts ({}) exceeded trying to communicate with ZooKeeper",
Expand Down
3 changes: 3 additions & 0 deletions core/src/test/java/org/apache/accumulo/core/fate/zookeeper/ZooReaderWriterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,9 @@ public void testMutateWithBadVersion() throws Exception {
// Let 2nd setData succeed
expect(zk.setData(path, mutatedBytes, 0)).andReturn(null);

retry.waitForNextAttempt(anyObject(), anyObject());
expectLastCall().once();

replay(zk, zrw, retryFactory, retry);

assertArrayEquals(new byte[] {1}, zrw.mutateOrCreate(path, value, mutator));
Expand Down