Improve the UniqueNameAllocator configurability#3736
Merged
ctubbsii merged 3 commits intoapache:2.1from Aug 29, 2023
Merged
Conversation
* Replace "base" and "jitter" concepts, which are confusing and require defining, with explicit "min" and "max" values for the configuration options for UniqueNameAllocator. Also adjust formatting of Property descriptions so they don't excessively exceed our line length style.
Member
Author
|
#3729 was merged before I had a chance to review it. Here's my suggestions to make the property names (and implementation) a bit more simple to understand. |
dlmarion
reviewed
Aug 29, 2023
ivakegg
approved these changes
Aug 29, 2023
keith-turner
approved these changes
Aug 29, 2023
EdColeman
pushed a commit
to EdColeman/accumulo
that referenced
this pull request
Sep 11, 2023
* Replace "base" and "jitter" concepts, which are confusing and require defining, with explicit "min" and "max" values for the configuration options for UniqueNameAllocator. Also adjust formatting of Property descriptions so they don't excessively exceed our line length style.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #3722