Skip to content

Added property to configure TCP backlog for Thrift server sockets#3752

Merged
dlmarion merged 2 commits intoapache:2.1from
dlmarion:3751-thrift-socket-backlog
Sep 14, 2023
Merged

Added property to configure TCP backlog for Thrift server sockets#3752
dlmarion merged 2 commits intoapache:2.1from
dlmarion:3751-thrift-socket-backlog

Conversation

@dlmarion
Copy link
Copy Markdown
Contributor

Closes #3751

@dlmarion dlmarion self-assigned this Sep 12, 2023
@dlmarion dlmarion linked an issue Sep 12, 2023 that may be closed by this pull request
@dlmarion
Copy link
Copy Markdown
Contributor Author

Kicked off full IT build

@ddanielr
Copy link
Copy Markdown
Contributor

Thrift was originally passing 0 for the backlog. Since ServerSocket uses 50 if backlog value is less than 1, this change shouldn't modify existing behavior.

https://github.com/openjdk/jdk/blob/a9679acd5c85b88afe827dc55dbe9a78b00c8918/src/java.base/share/classes/java/net/ServerSocket.java#L272-L273

Changes look good to me!

@dlmarion
Copy link
Copy Markdown
Contributor Author

Full IT build passed successfully.

@dlmarion dlmarion requested a review from ctubbsii September 13, 2023 16:50
@dlmarion dlmarion merged commit af5972e into apache:2.1 Sep 14, 2023
@dlmarion dlmarion deleted the 3751-thrift-socket-backlog branch September 14, 2023 16:38
@ctubbsii ctubbsii modified the milestones: 3.1.0, 2.1.3 Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need to be able to adjust the backlog on the thrift server socket

4 participants