Modify ClientTabletCacheImpl.findExtentsToHost end key comparison#3812
Merged
dlmarion merged 1 commit intoapache:elasticityfrom Oct 5, 2023
Merged
Conversation
it would preload Tablets for Scanners. It appears this change may have caused the test in apache#3809 to fail. I modified the comparison of the range to the tablet end key using the same logic that ThriftScanner uses and it fixed the test. Fixes apache#3809
keith-turner
approved these changes
Oct 4, 2023
dlmarion
added a commit
to dlmarion/accumulo
that referenced
this pull request
Oct 6, 2023
Revert change introduced in apache#3654 to ManagerAssignmentIT for an extra tablet being brought online, something that was introduced in apache#3429 and fixed in apache#3812.
dlmarion
added a commit
that referenced
this pull request
Oct 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change in #3429 modified ClientTabletCache so that it would preload Tablets for Scanners. It appears this change may have caused the test in #3809 to fail. I modified the comparison of the range to the tablet end key using the same logic that ThriftScanner uses and it fixed the test.
Fixes #3809