-
Notifications
You must be signed in to change notification settings - Fork 477
Add Sunny Tag to more tests for elasticity branch #3816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
FYI that I wanted to add the Sunny tag to |
|
Adding the test for bulk, merge, compaction, etc gives good high coverage of the major features of Accumulo. The following test seem to exercise internal impl details of the high level features that would be partially exercised by the test that exercise the high level features.
So thinking maybe these test should not be added. |
ctubbsii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of these tests seem like more than just quick smoke tests to make sure we haven't fundamentally broken some basic core functionality. I would not consider merges or all of the edge case scan server ITs to be basic core functionality, maybe not even bulk import. Yes, they are important, but they can be run when the full ITs run... or we can create a new category if needed. But, the purpose of the sunny tests are to quickly run checks, and adding a bunch more to them is going to make smoke testing contributions harder.
I would suggest rolling these out, and creating a new category for elasticity-related features, if there is a need for such a category. Maybe one or two of these could be added to sunny, but I don't think all of them should be.
|
@ctubbsii - @keith-turner and I talked about this and I think we both agreed that for now, for the elasticity branch, we are good with marking these as part of the sunny tests. These tests are being built periodically by a Jenkins server, it's not something that we are doing manually. All of the tests are not working yet on the elasticity branch and this gives us a good indication that the major features are working. We can revisit this when all of the ITs are working. |
This reverts commit bdac4cd.
No description provided.