Don't throw error when updateStatus has not run yet #3901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Manager.StatusThread.updateStatus has not run yet, then the set of current tablet server information will be empty.
Contributor
Author
|
I think this should supercede #3898 |
Fixes two bugs that could cause the set of tservers and map of group tservers to have an inconsistent set of tservers. Modified LiveTserverSet so that the set of tablet servers and the tablet servers resource groups can be acquired atomically. The code was acquiring this information at two different times with two different lock acquisitions, which could have led to race condtions resulting differences in set and the map. Also modified TGW.TabletLists to filter out shutting down servers from the grouped tservers in addition to filtering from the tserver set.
Contributor
keith-turner
left a comment
keith-turner
left a comment
There was a problem hiding this comment.
@dlmarion I was looking into this and opened a PR against this dlmarion#44
core/src/main/java/org/apache/accumulo/core/manager/balancer/AssignmentParamsImpl.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/accumulo/core/manager/balancer/AssignmentParamsImpl.java
Outdated
Show resolved
Hide resolved
LiveTseverSet is modified to keep a snapshot that is only recomputed on changes. It used to recompute for each request and it also used to keep multiple indexes up to date. The indexes are no longer kept up to date but instead are recomputed on demand which simplified the code in addition to making it more efficient.
…ssignmentParamsImpl.java Co-authored-by: Keith Turner <kturner@apache.org>
… into fix-bug-with-balancing
Acquires tablet servers and their groups atomically
keith-turner
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Manager.StatusThread.updateStatus has not run yet, then the set of current tablet server information will be empty.