Mark TSERV_LAST_LOCATION_MODE as deprecated#3973
Merged
dlmarion merged 2 commits intoapache:mainfrom Nov 27, 2023
Merged
Conversation
ctubbsii
reviewed
Nov 21, 2023
Member
ctubbsii
left a comment
ctubbsii
left a comment
There was a problem hiding this comment.
Looks fine, but the property description should be updated to help the user understand the deprecation.
Also, for the warnings suppressions, I wouldn't bother putting DEPRECATED_ prefix on the variable name, like Property DEPRECATED_x = Property.x. I would just do Property x = Property.x. It just makes it shorter, and the name isn't really helping us locate it for removal later. The warnings suppression is already doing that for us. But this is a style choice, and it's up to you.
EdColeman
approved these changes
Nov 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3971