Use a Map for volume replacements #4103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ctubbsii
commented
Dec 21, 2023
ctubbsii
commented
- Use LinkedHashMap for order-preserved mapping of volume replacements instead of a List of Pairs
- Use this to simplify VolumeUtil.switchVolume
- Rename VolumeUtil.switchVolumes to switchVolume so it's actually an overloaded method for LogEntry, rather than merely having a similar name
- Also remove redundant trace logging for switching volumes for LogEntry, say "No replacement available" instead of the more concerning-sounding "Could not find replacement" (which implies there's supposed to be one, when it's fine if there isn't), and include the FileType in the trace log when the replacement is found
* Use LinkedHashMap for order-preserved mapping of volume replacements instead of a List of Pairs * Use this to simplify VolumeUtil.switchVolume * Rename VolumeUtil.switchVolumes to switchVolume so it's actually an overloaded method for LogEntry, rather than merely having a similar name * Also remove redundant trace logging for switching volumes for LogEntry, say "No replacement available" instead of the more concerning-sounding "Could not find replacement" (which implies there's supposed to be one, when it's fine if there isn't), and include the FileType in the trace log when the replacement is found
DomGarguilo
approved these changes
Dec 21, 2023
Member
DomGarguilo
left a comment
DomGarguilo
left a comment
There was a problem hiding this comment.
Nice improvement. Wonder if there are any other cases like this that can be replaced with a Map.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.