-
Notifications
You must be signed in to change notification settings - Fork 477
Added Indication of Intermediate Compactions to CompactionConfigurer #4118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changes - Added getSelectedFiles() method to CompactionConfigurer.InputParameters - Added method functionality in the two implementations of this: ShellCompactCommandConfigurerTest and CompactableUtils - Tested functionality in new IT: testGetSelectedFilesForCompaction() in CompactionIT - Added new method getCompressionType() to PrintBCInfo (used in the test) - Changed several method signatures to pass around necessary info for getSelectedFiles() implementations - Renamed 'files' variable to 'inputFiles' in CompactableUtils and CompactableImpl for a more clear distinction between inputFiles and the (new) selectedFiles. Potentially still left TODO: - Add this functionality for external compactions? - Move CompressionTypeConfigurer to it's own class?
core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/PrintBCInfo.java
Outdated
Show resolved
Hide resolved
| * <ul> | ||
| * <li>There is no selected set of files so the empty set is returned.</li> | ||
| * </ul> | ||
| */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new API method so needs a since tag.
| */ | |
| * | |
| * @since 3.1 | |
| */ |
If you added the new method to all impls of CompactionConfigurer then I would think this case is already covered. However I did not actually follow the code to be sure. |
Okay thanks! I did add the new method to the implementations of CompactionConfigurer. |
|
@kevinrr888 - there are some todo's in the description that seem like they might be worth while for someone to pursue. Have those been captured in an issue? |
|
@EdColeman thanks for pointing these out. The external compactions todo has been completed in this issue (I originally wasn't sure if my changes also worked for external compactions, but they do). The todo about moving the class probably isn't needed and is probably better suited for where it is now since it's currently only used in CompactionIT. |
Closes #3937
Changes:
Potentially still left TODO: