Skip to content

Small improvements to new AccumuloStore related code#4121

Merged
DomGarguilo merged 2 commits intoapache:elasticityfrom
DomGarguilo:accumuloStoreImprovements
Jan 4, 2024
Merged

Small improvements to new AccumuloStore related code#4121
DomGarguilo merged 2 commits intoapache:elasticityfrom
DomGarguilo:accumuloStoreImprovements

Conversation

@DomGarguilo
Copy link
Member

No description provided.

@DomGarguilo DomGarguilo requested a review from cshannon December 28, 2023 19:39
@EdColeman
Copy link
Contributor

EdColeman commented Jan 3, 2024

Does this set up a merge conflict with #4126 ? Not necessarily a problem more of something to watch out for depending on the merge order.

@DomGarguilo
Copy link
Member Author

Does this set up a merge conflict with #4126 ? Not necessarily a problem more of something to watch out for depending on the merge order.

Yea looks like there is some overlap but shouldn't be too much of a process to resolve.

Copy link
Contributor

@cshannon cshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, the only thing is the changes in AbstractFateStore exist in 2.1 and main already in ZooStore as that code was refactored in elasticity so we should probably also make the same changes there. I don't think changing things there first would merge forward easily with the refactor so we could just merge this PR and then create another PR to backport the changes to 2.1 and main and then merge an empty commit forward into elasticity

@DomGarguilo DomGarguilo merged commit e7d789d into apache:elasticity Jan 4, 2024
@DomGarguilo DomGarguilo deleted the accumuloStoreImprovements branch January 4, 2024 19:37
@ctubbsii ctubbsii added this to the 4.0.0 milestone Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants