Fixes CompactionIT.testMultiStepCompactionThatDeletesAll()#4259
Closed
keith-turner wants to merge 1 commit intoapache:elasticityfrom
Closed
Fixes CompactionIT.testMultiStepCompactionThatDeletesAll()#4259keith-turner wants to merge 1 commit intoapache:elasticityfrom
keith-turner wants to merge 1 commit intoapache:elasticityfrom
Conversation
CompactionIT.countFiles() was counting in an overly broad way that included the new +fate table and the new availability columns in ~tab. This was causing a test failure. Narrowed the scope of countFiles to fix this.
EdColeman
approved these changes
Feb 12, 2024
Contributor
|
This is targeted for elasticity. Would any of the similar compaction tests in main benefit from a similar narrowing? Or is this strictly unique to elasticity? Could be out of scope for this change, but didn't want to pass up an opportunity if we could improve the compaction tests in general. |
keith-turner
added a commit
that referenced
this pull request
Feb 13, 2024
CompactionIT.countFiles() was counting in an overly broad way. In the elasticity branch that included the new +fate table and the new availability columns in ~tab. This was causing a test failure. Narrowed the scope of countFiles to fix this. Even though the test was not broken in 2.1, the test fixes were made there because its a general improvement to the test.
Contributor
Author
|
Made the change in 2.1 and merged forward |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CompactionIT.countFiles() was counting in an overly broad way that included the new +fate table and the new availability columns in ~tab. This was causing a test failure. Narrowed the scope of countFiles to fix this.