Skip to content

Conversation

@DomGarguilo
Copy link
Member

This PR addresses the following from CompactorGroupId:

// ELASTICITY_TODO make this cache ids like TableId. This will help save manager memory.
  • I removed the impl since the only thing it seemed to be doing was instantiating a CompactorGroupId object.
  • Added a static method to create a new object or get it from the cache (modeled after TableId)

@DomGarguilo DomGarguilo self-assigned this Feb 27, 2024
Copy link
Contributor

@ddanielr ddanielr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the build test errors are fixed I think this is good!

@DomGarguilo DomGarguilo merged commit b926c89 into apache:elasticity Feb 28, 2024
@DomGarguilo DomGarguilo deleted the replaceCompImpl branch February 28, 2024 14:17
@ctubbsii ctubbsii added this to the 4.0.0 milestone Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants