fixes conditional mutation bug when loading tablet #4447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In apache#4436 a tablet update was moved to use conditional mutations. The changed checked tablets current location in the conditional update. However when this code was called in the Tablet constructor the tablet server was the future location. Adjusted to code to check for the future location when calling from the constructor.
Contributor
Author
|
Multiple log recovery test were failing in the build, this change should fix them. Ran a subset of the failing ones and they passed. |
dlmarion
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #4436 a tablet update was moved to use conditional mutations. The changed checked tablets current location in the conditional update. However when this code was called in the Tablet constructor the tablet server was the future location. Adjusted to code to check for the future location when calling from the constructor.