Fixed NPE in ScanServerMetrics #4598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A NPE was being raised in ScanServerMetrics.registerMetrics when the SSERV_CACHED_TABLET_METADATA_EXPIRATION value was zero, which disables the tablet metadata caching and leaves the variable tabletMetadataCache referencing null. A test was failing in ScanServerConcurrentTabletScanIT that led to this discovery.
EdColeman
approved these changes
May 23, 2024
DomGarguilo
approved these changes
May 23, 2024
Member
DomGarguilo
left a comment
DomGarguilo
left a comment
There was a problem hiding this comment.
Confirmed that this change allows for the mentioned test to pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A NPE was being raised in ScanServerMetrics.registerMetrics when the SSERV_CACHED_TABLET_METADATA_EXPIRATION value was zero, which disables the tablet metadata caching and leaves the variable tabletMetadataCache referencing null. A test was failing in ScanServerConcurrentTabletScanIT that led to this discovery.