Skip to content

Add metric that indicates when compactor is busy#4622

Merged
DomGarguilo merged 7 commits intoapache:2.1from
DomGarguilo:addCompactorBusyMetric
Jun 6, 2024
Merged

Add metric that indicates when compactor is busy#4622
DomGarguilo merged 7 commits intoapache:2.1from
DomGarguilo:addCompactorBusyMetric

Conversation

@DomGarguilo
Copy link
Member

@DomGarguilo DomGarguilo commented May 31, 2024

Fixes #4569

@DomGarguilo DomGarguilo self-assigned this May 31, 2024
@DomGarguilo
Copy link
Member Author

DomGarguilo commented May 31, 2024

This is slightly outside of the scope of this PR but its close enough that I think it can be addressed here:

When running the test case that I added to in this PR, testProgressViaMetrics(), I see different values for the number of entries read and written by the compactor. The entries read is either 9216 or 18432 (double 9216). The entries written is either 4096 or 13312 (3.5 times 4096). I am not sure where this discrepancy is coming from between runs but I am wondering what the best solution for this is. My current thinking is that we just check that these values are above zero in the test as opposed to any specific value.

keith-turner
keith-turner approved these changes Jun 6, 2024
View reviewed changes
@DomGarguilo DomGarguilo merged commit 528711e into apache:2.1 Jun 6, 2024
@DomGarguilo DomGarguilo deleted the addCompactorBusyMetric branch June 6, 2024 15:32
@ctubbsii ctubbsii modified the milestones: 3.1.0, 2.1.3 Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dlmarion dlmarion dlmarion left review comments

@ddanielr ddanielr ddanielr left review comments

@keith-turner keith-turner keith-turner approved these changes

Assignees

@DomGarguilo DomGarguilo

Labels

None yet

Projects

None yet

Milestone

2.1.3

Development

Successfully merging this pull request may close these issues.

5 participants

@DomGarguilo @dlmarion @keith-turner @ddanielr @ctubbsii