Moves reading root tablet metadata w/ zoocache out of Ample#4673
Merged
keith-turner merged 1 commit intoapache:elasticityfrom Jun 14, 2024
Merged
Conversation
After the changes in apache#4669 only a single location in the code was reading tablet metadata w/ eventual consistency using Ample. This single location was the root tablet location cache. Since this was the only use of the code and its a highly nuanced use case, moved the code out of Ample to the only place that was using it. Removing the levels of indirection makes it easier to understand the root tablet location cache. Also added some comments about what the the root tablet location cache is doing and noticed and uneeded cache clear it was doing and removed it.
keith-turner
commented
Jun 14, 2024
| @Override | ||
| public void invalidateCache(ClientContext context, String server) { | ||
| ZooCache zooCache = context.getZooCache(); | ||
| String root = context.getZooKeeperRoot() + Constants.ZTSERVERS; |
Contributor
Author
There was a problem hiding this comment.
This seems like a bug. Its clearing something that has nothing to do w/ the root tablet metadata stored in zookeeper. So removed it. It probably not really hurting anything. Thought about back porting a change to remove these lines in earlier versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the changes in #4669 only a single location in the code was reading tablet metadata w/ eventual consistency using Ample. This single location was the root tablet location cache. Since this was the only use of the code and its a highly nuanced use case, moved the code out of Ample to the only place that was using it. Removing the levels of indirection makes it easier to understand the root tablet location cache. Also added some comments about what the the root tablet location cache is doing and noticed and uneeded cache clear it was doing and removed it.