Backport fix to make Import tablet idempotent #4676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This backports the fix from apache#4646 to make MoveExportedFiles fate step idempotent. This closes apache#4655
keith-turner
approved these changes
Jun 14, 2024
Contributor
Author
|
Oops, I meant to target 2.1 so I will cherry-pick it and merge forward. |
cshannon
added a commit
that referenced
this pull request
Jun 14, 2024
Contributor
Author
|
Applied to 2.1 in 930a841 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports the fix from #4646 to make MoveExportedFiles fate step idempotent.
This closes #4655
Note: ComprehensiveIT does not exist in 2.1 so those changes that were part of #4646 were not backported. I think there are other ITs that exist for table import though, so I wasn't sure if we wanted to test this in some other way or bring back that test and the flaky comprehensive test too. The test does exist in main so we could maybe add it there.