Skip to content

Improve ActiveCompactionHelper retrieval methods #4677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DomGarguilo merged 1 commit into from
Jun 14, 2024
Merged

Improve ActiveCompactionHelper retrieval methods #4677

DomGarguilo merged 1 commit into from
Jun 14, 2024

Conversation

@DomGarguilo
Copy link
Member

@DomGarguilo DomGarguilo commented Jun 14, 2024

  • remove the need to create lists and just use a single stream per method
  • create static final Comparator for reuse in both methods. Improve age comparison
  • rename stream() to activeCompactions() for consistency

@DomGarguilo DomGarguilo merged commit b2a78dd into apache:2.1 Jun 14, 2024
@DomGarguilo DomGarguilo deleted the improveActiveCompactionHelperMethods branch June 18, 2024 15:55
@DomGarguilo DomGarguilo added this to the 2.1.3 milestone Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keith-turner keith-turner keith-turner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.1.3

Development

Successfully merging this pull request may close these issues.

2 participants

@DomGarguilo @keith-turner